Ian/clone thread #161
Merged
Ian/clone thread #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
|
hey! just wondering if there’s any reason this one hasn’t been merged yet? |
|
@KevinGrajeda not a good one. I cut it for folks to try out & give feedback but never got confirmation that it solved the problem so it just sat. Have you tried it? Does it work for you? |
|
@ianmacartney i'll try it and get back to you |
|
@ianmacartney confirming that works for me, I’m using this version in production because my hand‑rolled approach was breaking on larger threads, but this one has been working flawlessly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the vein of #33 , allows cloning messages from a thread into a new thread up to some point, adding at some offset.
It avoids copying if messages exist at that new order/stepOrder
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.